Fix/windows overflow #364
Closed
Fix/windows overflow #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Closing this PR as the issue has been fixed more comprehensively in PR #382 (merged July 2025). The current master code now uses a vectorized PCG hash approach with Thank you @baogorek for identifying this issue and proposing an initial fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this fixes and how it's fixed
Fixes #363. Moving from instantiating a different generator per entity to a single random number sequence seeded by the minimum entity id saves about 10 seconds. As long as entity id is not negative, our seed will not be negative.